Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users ftp delete function #208

Conversation

Boschung-Mecatronic-AG-Infrastructure
Copy link
Contributor

Adding delete_file function for ftp

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cyberw
Copy link
Collaborator

cyberw commented Feb 14, 2025

Nice! Could you take the time to fix an issue: request_type should be just "FTP" and request_method should be the name of the call (using ftp cli names like send, get, delete etc)

Oh, and check the linting errors.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…unction delete_file
@Boschung-Mecatronic-AG-Infrastructure
Copy link
Contributor Author

Hi, @cyberw are changes OK for you?

@cyberw
Copy link
Collaborator

cyberw commented Feb 17, 2025

Hi! Almost. I want you to set request_method too:

request_method should be the name of the call (using ftp cli names like send, get, delete etc)

@cyberw cyberw merged commit c183bc2 into SvenskaSpel:master Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants