Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug | Illegal RegExp in Safari in 3.0.0-beta.1 and beta.2 #1444

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

nambiarAswathi
Copy link
Contributor

Since the upgrade from 3.0.0-alpha6 to beta2, there is an issue on old Safari versions. The Html widget renders as a grey area and and the console the error is:

FormatException: Illegal RegExp pattern (SyntaxError: Invalid regular expression: invalid group specifier name)
(?<=\n) *

@Sub6Resources
Copy link
Owner

Thanks for the contribution. Whitespace bugs are among the most common issues reports I receive, so let me write a few unit tests to verify that this RegExp change still handles all the edge cases correctly. If so, then we can merge this, otherwise I'll probably have to write a custom code to handle these whitespace replacements to support Safari

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.07%. Comparing base (2814407) to head (231dfc5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
- Coverage   64.08%   64.07%   -0.02%     
==========================================
  Files          39       39              
  Lines        3032     3031       -1     
==========================================
- Hits         1943     1942       -1     
  Misses       1089     1089              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sub6Resources Sub6Resources merged commit 8cee321 into Sub6Resources:master Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants