fix(windows): don't automatically delete files on open #344
+11
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried doing this to match the behavior on Unix platforms but this appears to trigger some form of Windows kernel bug at scale. Given that it's not necessary, we're reverting it. I'm leaving the feature flag in the `Cargo.toml` for now but will remove it in the near future. fixes #339
Stebalien
force-pushed
the
steb/revert-delete-on-windows
branch
from
ff57807 to
44f285f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried doing this to match the behavior on Unix platforms but this appears to trigger some form of Windows kernel bug at scale. Given that it's not necessary, we're reverting it. I'm leaving the feature flag in the
Cargo.tomlfor now but will remove it in the near future.fixes #339