Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include linux arm64 binary #281

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

jogu
Copy link
Contributor

@jogu jogu commented Apr 6, 2023

This should mean hoverfly works within docker images running on arm macs, which currently doesn't work as discussed here:

https://gitlab.com/openid/conformance-suite/-/commit/5bf13143f3d5ac37048436357749bea6a7c78c8b#note_1343474787

This should mean hoverly works within docker images running on arm macs, which currently doesn't work as discussed here:

https://gitlab.com/openid/conformance-suite/-/commit/5bf13143f3d5ac37048436357749bea6a7c78c8b#note_1343474787
@jogu
Copy link
Contributor Author

jogu commented Apr 6, 2023

I haven't tested this change, as I'm not actually sure how I could test it.

@zandbelt
Copy link

zandbelt commented Apr 6, 2023

I haven't tested this change, as I'm not actually sure how I could test it.

Adding that file manually to the jar file (binaries/hoverfly_linux_arm64) works for me indeed.

Copy link
Member

@tommysitu tommysitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it was missing the binary for the linux arm64 machine.

@tommysitu tommysitu merged commit e1d8e5c into SpectoLabs:master May 8, 2023
@jogu jogu deleted the fix-arm-linux branch May 9, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants