Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Refactor publish logic to support OCI remote and deduplicate code #162

Conversation

DEiselt
Copy link
Contributor

@DEiselt DEiselt commented Oct 16, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #159

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Sorry, something went wrong.

@DEiselt DEiselt requested a review from jschoone October 16, 2024 11:59
@DEiselt DEiselt changed the title added: allow switch for assetclient in create command Refactor publish logic to support OCI remote and deduplicate code Oct 22, 2024
@DEiselt DEiselt marked this pull request as ready for review October 22, 2024 09:12
@DEiselt DEiselt changed the title Refactor publish logic to support OCI remote and deduplicate code ✨ Refactor publish logic to support OCI remote and deduplicate code Oct 22, 2024
@jschoone jschoone force-pushed the 159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted branch from 1519dea to ac775e8 Compare October 23, 2024 09:55

Verified

This commit was signed with the committer’s verified signature.
bdehamer Brian DeHamer
added: allow switch for assetclient in create command
added: `--publish` flag for create command
removed: unused code changes from last commit
changed: moved `pushReleaseAssets` function to `create.go`
removed: publish command and `publish.go` file
changed: help text format
chore: go mod tidy
chore(create): reactivate validateHash
fix: make linter happy

Signed-off-by: Danny Eiselt <eiselt@b1-systems.de>
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
@jschoone jschoone force-pushed the 159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted branch from ac775e8 to 65e18de Compare October 23, 2024 10:01

Verified

This commit was signed with the committer’s verified signature.
bdehamer Brian DeHamer
…for-last-release-even-when-oci-is-wanted
@jschoone jschoone merged commit 5bf6153 into main Oct 23, 2024
8 checks passed
@jschoone jschoone deleted the 159-bug-create-command-always-checks-github-for-last-release-even-when-oci-is-wanted branch October 23, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 create command always checks GitHub for last release, even when OCI is wanted
2 participants