Skip to content

Commit 783b8ba

Browse files
authoredJul 4, 2024
🐛 Add correct K8s version in metadata.yaml (#141)
We have overwritten the K8s version of the new cluster stack release by the one in the old release. This commit makes sure that we don't overwrite it. Signed-off-by: janiskemper <janis.kemper@syself.com>
1 parent ff77a29 commit 783b8ba

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed
 

‎pkg/cmd/create.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,6 @@ func GetCreateOptions(ctx context.Context, clusterStackPath string) (*CreateOpti
135135
return nil, fmt.Errorf("failed to create new github client: %w", err)
136136
}
137137

138-
// update the metadata kubernetes version with the csctl.yaml config
139-
createOption.Metadata.Versions.Kubernetes = config.Config.KubernetesVersion
140-
141138
latestRepoRelease, err := github.GetLatestReleaseFromRemoteRepository(ctx, mode, config, gc)
142139
if err != nil {
143140
return nil, fmt.Errorf("failed to get latest release form remote repository: %w", err)
@@ -159,6 +156,9 @@ func GetCreateOptions(ctx context.Context, clusterStackPath string) (*CreateOpti
159156
if err != nil {
160157
return nil, fmt.Errorf("failed to handle stable mode: %w", err)
161158
}
159+
160+
// update the metadata kubernetes version with the csctl.yaml config
161+
createOption.Metadata.Versions.Kubernetes = config.Config.KubernetesVersion
162162
}
163163
case customMode:
164164
if clusterStackVersion == "" {
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
values: |
2-
metrics-server:
3-
commonLabels:
4-
domain: "{{ .Cluster.spec.controlPlaneEndpoint.host }}"
5-
clusterAddonVersion: "v2"
1+
metrics-server:
2+
commonLabels:
3+
domain: "{{ .Cluster.spec.controlPlaneEndpoint.host }}"
4+
clusterAddonVersion: "v2"
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
apiVersion: v2
22
description: |
33
This chart installs and configures:
4-
* Docker Ferrol Cluster Class
4+
* Docker Valencia Cluster Class
55
maintainers:
66
- name: Syself
77
email: info@syself.com
88
url: https://github.com/syself
9-
name: docker-ferrol-1-27-cluster-class
9+
name: docker-valencia-1-27-cluster-class
1010
type: application
1111
version: << .ClusterAddonVersion >>

0 commit comments

Comments
 (0)
Please sign in to comment.