Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why CI doesn't cache trybuild dependencies #735

Closed
neysofu opened this issue Aug 25, 2023 · 2 comments
Closed

Investigate why CI doesn't cache trybuild dependencies #735

neysofu opened this issue Aug 25, 2023 · 2 comments
Assignees
@vlopes11 @neysofu
Labels
ci Everyting related to CI (Continuous integration) Small Use this label for quick cleanup and maintenance tasks

Comments

@neysofu
Copy link
Member

neysofu commented Aug 25, 2023 •
edited

Summary

Dependencies of our trybuild tests are never re-used, which causes significant longer CI times for the test and coverage jobs.

        SLOW [>300.000s] sov-modules-macros::tests cli_wallet_arg_tests
        SLOW [>300.000s] sov-modules-macros::tests module_dispatch_tests
        SLOW [>300.000s] sov-modules-macros::tests module_info_tests
        ...

Possibly related issues:
@neysofu neysofu added ci Everyting related to CI (Continuous integration) Small Use this label for quick cleanup and maintenance tasks labels Aug 25, 2023
@neysofu
Copy link
Member Author

neysofu commented Aug 25, 2023

May be because trybuild stores some data in target/tests/trybuild, which https://github.com/Swatinem/rust-cache then promptly removes: https://github.com/Swatinem/rust-cache/blob/44b60872836a3f1d4d9abcebaf6e5c4964a5a2ab/src/cleanup.ts#L37.

@neysofu neysofu mentioned this issue Aug 26, 2023
Merged
@neysofu neysofu self-assigned this Aug 28, 2023
@vlopes11 vlopes11 self-assigned this Sep 11, 2023
@neysofu
Copy link
Member Author

neysofu commented Sep 12, 2023

Closed by Swatinem/rust-cache#168. Judging by our latest CI runs:

  • test went from 8m39s to 3m31s
  • coverage went from 6m26s to 3m29s

@neysofu neysofu closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlopes11 vlopes11

@neysofu neysofu

Labels
ci Everyting related to CI (Continuous integration) Small Use this label for quick cleanup and maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlopes11 @neysofu