SONARPY-2193: Update sonarlint-core.version to v10 (major) #2068
+131
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joke1196
force-pushed
the
SONARPY-2193
branch
2 times, most recently
from
046c5af to
5ae09ba
Compare
joke1196
force-pushed
the
SONARPY-2193
branch
from
5ae09ba to
9072c79
Compare
Seppli11
approved these changes
Oct 14, 2024
Comment on lines
124
to
126
| List<String> logs = logsByLevel.getOrDefault(level, new ArrayList<>()); | ||
| logs.add(formattedMessage); | ||
| logsByLevel.putIfAbsent(level, logs); |
There was a problem hiding this comment.
I find the version above a bit more concise
Suggested change
| List<String> logs = logsByLevel.getOrDefault(level, new ArrayList<>()); | |
| logs.add(formattedMessage); | |
| logsByLevel.putIfAbsent(level, logs); | |
| logsByLevel.computeIfAbsent(level, k -> new ArrayList<>()).add(formattedMessage); |
There was a problem hiding this comment.
Would it maybe make sense to change this class's name to SonarLintIPythonTest or similar, to reflect that it does the something as SonarLint but for ipython?
There was a problem hiding this comment.
Yes I think it makes a lot of sense!
joke1196
force-pushed
the
SONARPY-2193
branch
from
0bd8487 to
8bf2c49
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.