Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Razor source generators from SDK #9212

Closed
CristianAmbrosini opened this issue Apr 26, 2024 · 0 comments · Fixed by #9210
Closed

Load Razor source generators from SDK #9212

CristianAmbrosini opened this issue Apr 26, 2024 · 0 comments · Fixed by #9210
Assignees
@CristianAmbrosini
Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban

Comments

@CristianAmbrosini
Copy link
Contributor

We should change the temporary workaround for sonar-dotnet in-memory compilation for razor UTs, which is embedding the 8.103 source generators DLLs.

To make this future-proof, we should load the source generators from the SDK instead.

More details
@CristianAmbrosini CristianAmbrosini mentioned this issue Apr 26, 2024
Merged
@CristianAmbrosini CristianAmbrosini linked a pull request Apr 26, 2024 that will close this issue
Load Razor source generators from SDK #9210
Merged
@github-actions github-actions bot added this to Review in progress in Best Kanban Apr 26, 2024
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Type: Tooling Tools make us productive. label May 2, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 3, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 3, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 3, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 3, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 3, 2024
@github-actions github-actions bot moved this from Review approved to In progress in Best Kanban May 7, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 7, 2024
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban May 7, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban May 7, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban May 7, 2024
Best Kanban automation moved this from Review approved to Validate Peach May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CristianAmbrosini CristianAmbrosini

Labels
Sprint: Razor UTs Type: Tooling Tools make us productive.
Projects
Best Kanban
  
Validate Peach
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load Razor source generators from SDK SonarSource/sonar-dotnet
3 participants
@Tim-Pohlmann @pavel-mikula-sonarsource @CristianAmbrosini