Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule T0033: Swap the logic to use positive conditions instead #9166

Open
pavel-mikula-sonarsource opened this issue Apr 19, 2024 · 0 comments
Open

New Rule T0033: Swap the logic to use positive conditions instead #9166

pavel-mikula-sonarsource opened this issue Apr 19, 2024 · 0 comments
Labels
Type: Tooling Tools make us productive.

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Apr 19, 2024 •
edited

Coding style:

Use positive logic.

if(!empty)  // Noncompliant
  return value;
else
  return null;

return !empty // Noncompliant
  ? value;
  : null;

return !condition && !condition && !condition // Noncompliant
  ? value
  : null;

return !condition && (condition || condition) // Compliant
  ? value
  : null

return !condition && condition // Compliant
  ? value
  : null
@pavel-mikula-sonarsource pavel-mikula-sonarsource added the Type: Tooling Tools make us productive. label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Tooling Tools make us productive.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavel-mikula-sonarsource