New Rule T0009: Order the same member kind by its accessibility #9136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-mikula-sonarsource
force-pushed
the
Pavel/T0009
branch
from
b6483c5
to
ef33ba7
Compare
pavel-mikula-sonarsource
force-pushed
the
Pavel/T0009
branch
from
ef33ba7
to
5e74ac6
Compare
|
|
sebastien-marichal
approved these changes
Apr 18, 2024
Comment on lines
+23
to
+32
| private int private1; | ||
|
|
||
| protected int protectedVariant1; // Noncompliant {{Move this protected Field above the private ones.}} | ||
| private protected int protectedVariant2; // Noncompliant {{Move this protected Field above the private ones.}} | ||
| protected internal int protectedVariant3; // Noncompliant {{Move this protected Field above the private ones.}} | ||
|
|
||
| public int publicOrInternal1; // Noncompliant {{Move this public Field above the private ones.}} | ||
| internal int publicOrInternal2; // Noncompliant {{Move this internal Field above the private ones.}} | ||
| public int publicOrInternal3; // Noncompliant {{Move this public Field above the private ones.}} | ||
| internal int publicOrInternal4; // Noncompliant {{Move this internal Field above the private ones.}} |
There was a problem hiding this comment.
I was confused by why all the issues had the same message before I realized they were all talking about the first field.
If not too much effort, we could add a secondary location.
There was a problem hiding this comment.
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9045