Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule S6966: Awaitable method should be used #9096

Closed
zsolt-kolbay-sonarsource opened this issue Apr 15, 2024 · 1 comment · Fixed by #9101 or #9179
Closed

New Rule S6966: Awaitable method should be used #9096

zsolt-kolbay-sonarsource opened this issue Apr 15, 2024 · 1 comment · Fixed by #9101 or #9179
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
Best Kanban
Milestone
9.25

Comments

@zsolt-kolbay-sonarsource
Copy link
Contributor

RSPEC: SonarSource/rspec#3854
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource added Area: C# C# rules related issues. Type: New Rule Implementation for a rule that HAS been specified. Sprint: ASP.NET MVC labels Apr 15, 2024
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource added this to the 9.24 milestone Apr 15, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from To do to In progress in Best Kanban Apr 15, 2024
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 17, 2024
@jilles-sg
Copy link

This rule may be useful to complete the final parts of an migration to async or to help prevent incorrect sync calls being added. However, there are cases where a normally asynchronous (I/O) type is synchronous, such as MemoryStream, StringReader, StringWriter or a StreamWriter that writes to a MemoryStream. In such cases, the asynchronous calls are unnecessary overhead. This is particularly nasty when await using has to be used with .ConfigureAwait(false), since a separate variable is required to store the ConfiguredAsyncDisposable.

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Apr 18, 2024
@github-actions github-actions bot moved this from Review approved to Review in progress in Best Kanban Apr 18, 2024
Best Kanban automation moved this from Review in progress to Validate Peach Apr 19, 2024
Merged
4 tasks
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to In progress in Best Kanban Apr 22, 2024
@Tim-Pohlmann Tim-Pohlmann modified the milestones: 9.24, 9.25 Apr 23, 2024
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Apr 23, 2024
Best Kanban automation moved this from Review in progress to Validate Peach Apr 24, 2024
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Type: New Rule Implementation for a rule that HAS been specified.
Projects
Best Kanban
  
Done
Milestone
9.25
4 participants
@jilles-sg @Tim-Pohlmann @martin-strecker-sonarsource @zsolt-kolbay-sonarsource