Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE: Fix S4158 FP: Interfaces are only half tracked #7941

Merged
merged 5 commits into from
Sep 1, 2023
Merged

SE: Fix S4158 FP: Interfaces are only half tracked #7941

merged 5 commits into from
Sep 1, 2023

Conversation

Tim-Pohlmann
Copy link
Contributor 

IList<int> iList = new List<int>();
iList.Add(5);
iList.Clear();                                      // Noncompliant FP

@Tim-Pohlmann Tim-Pohlmann added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label Sep 1, 2023
@github-actions github-actions bot added this to In progress in Best Kanban Sep 1, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Sep 1, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small nitpick + needs some more tests (discussed offline).

...nalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyCollectionsShouldNotBeEnumerated.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Sep 1, 2023
Tim-Pohlmann and others added 2 commits September 1, 2023 16:05
@Tim-Pohlmann @mary-georgiou-sonarsource
Review 1
b787a69 
Co-authored-by: Mary Georgiou <89914005+mary-georgiou-sonarsource@users.noreply.github.com>
@Tim-Pohlmann
Review 2
95dd907
@github-actions github-actions bot moved this from Review approved to Review in progress in Best Kanban Sep 1, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more tests.

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Tim-Pohlmann
Copy link
Contributor Author

This is not part of a milestone. The bug was just introduced by #7933

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tim-Pohlmann Tim-Pohlmann merged commit a1541b1 into master Sep 1, 2023
25 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Sep 1, 2023
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/Fix_CollectionInterfaces branch September 1, 2023 14:48
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Validate Peach to Done in Best Kanban Sep 4, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.9 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Milestone
9.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tim-Pohlmann @mary-georgiou-sonarsource