Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BUILD-3017 use tokens for JFrog Artifactory instead of api ke… #7937

Merged
merged 1 commit into from Sep 1, 2023

Conversation

andrei-epure-sonarsource
Copy link
Contributor

This reverts commit 858a1da.

Promotion does not work.

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's wait for REs to reply if old credentials will still work before merging.

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Sep 1, 2023
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrei-epure-sonarsource andrei-epure-sonarsource merged commit 7f52a74 into master Sep 1, 2023
26 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Sep 1, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource deleted the andrei/revert-token branch September 1, 2023 08:30
@andrei-epure-sonarsource
Copy link
Contributor Author

I merged it, worst case scenario I will have to get back to the previous one in order to fix promotion.
We will get feedback from the pipeline in ~30 minutes whether the promotion worked, after which peach can be deployed.

@andrei-epure-sonarsource andrei-epure-sonarsource moved this from Validate Peach to Done in Best Kanban Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants