Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSPEC before release #7934

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

Tim-Pohlmann
Copy link
Contributor

No description provided.

@github-actions github-actions bot added this to In progress in Best Kanban Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -9,8 +9,10 @@
},
"status": "ready",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
"func": "Linear with offset",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this change should be explicit in the release notes, because it will affect the ratings

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tim-Pohlmann Tim-Pohlmann added this to the 9.9 milestone Aug 31, 2023
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Aug 31, 2023
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Aug 31, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Update RSPEC Update RSPEC before release Aug 31, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 598c579 into master Aug 31, 2023
28 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Aug 31, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the Tim/Update_Rspec branch August 31, 2023 15:24
@Tim-Pohlmann Tim-Pohlmann linked an issue Aug 31, 2023 that may be closed by this pull request
@Tim-Pohlmann Tim-Pohlmann removed this from Validate Peach in Best Kanban Aug 31, 2023
@Tim-Pohlmann Tim-Pohlmann removed this from the 9.9 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RSPEC before 9.9 release
3 participants