Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SE: Do not learn CollectionConstraints for untracked collections #7933

Merged
merged 3 commits into from
Aug 31, 2023
Merged

SE: Do not learn CollectionConstraints for untracked collections #7933

merged 3 commits into from
Aug 31, 2023

Conversation

Tim-Pohlmann
Copy link
Contributor 

var sb = new StringBuilder();
sb.Clear();
sb.Clear();    // Noncompliant FP

@Tim-Pohlmann Tim-Pohlmann added the Sprint: SE Short-lived* label for epic MMF-3077 *troll label Aug 31, 2023
@github-actions github-actions bot added this to Review in progress in Best Kanban Aug 31, 2023
mary-georgiou-sonarsource
mary-georgiou-sonarsource reviewed Aug 31, 2023
View reviewed changes
...nalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyCollectionsShouldNotBeEnumerated.cs
{
var sb = new StringBuilder();
sb.Clear();
sb.Clear(); // Compliant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment here on why we don't track this.
From my understanding is that we might track the string builder in the future.

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Aug 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Tim-Pohlmann Tim-Pohlmann merged commit 668e37d into master Aug 31, 2023
22 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Aug 31, 2023
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/fix_untracked_collections branch August 31, 2023 14:08
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Validate Peach to Done in Best Kanban Sep 1, 2023
@Tim-Pohlmann Tim-Pohlmann mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: SE Short-lived* label for epic MMF-3077 *troll
Projects
Best Kanban
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tim-Pohlmann @mary-georgiou-sonarsource