Retrieve file path from pragma checksum #7912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
costin-zaharia-sonarsource
requested a review
from cristian-ambrosini-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned costin-zaharia-sonarsource
costin-zaharia-sonarsource
force-pushed
the
costin/syntax-node-path
branch
from
87ceae1
to
d1000e1
Compare
cristian-ambrosini-sonarsource
suggested changes
Aug 29, 2023
analyzers/src/SonarAnalyzer.Common/Helpers/SyntaxNodeExtensions.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/Extensions/SyntaxNodeExtensionsTest.cs
Show resolved
Hide resolved
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned cristian-ambrosini-sonarsource
costin-zaharia-sonarsource
force-pushed
the
costin/syntax-node-path
branch
from
d1000e1
to
bfb478f
Compare
costin-zaharia-sonarsource
requested a review
from cristian-ambrosini-sonarsource
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned costin-zaharia-sonarsource
cristian-ambrosini-sonarsource
approved these changes
Aug 30, 2023
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned cristian-ambrosini-sonarsource
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -38,7 +38,7 @@ public static bool IsGenerated(this SyntaxTree tree, GeneratedCodeRecognizer gen | |||
| return false; | |||
| } | |||
| var cache = GeneratedCodeCache.GetOrCreateValue(compilation); | |||
| // Hotpath: Don't use cache.GetOrAdd that takes a factory method. It allocates a delegate which causes GC preasure. | |||
| // Hot path: Don't use cache.GetOrAdd that takes a factory method. It allocates a delegate which causes GC preasure. | |||
There was a problem hiding this comment.
Was supposed to be pressure, instead of preasure?
There was a problem hiding this comment.
I've noticed that typo a bit later and fixed it in: https://github.com/SonarSource/sonar-dotnet/pull/7916/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7894