Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S112 FN: When using null-coalesce operator #7911

Merged
merged 5 commits into from Aug 29, 2023

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource commented Aug 29, 2023

Fixes #7910

Review per commit should be easier due to the cleanup phase

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Fix S112 FN when using null-coalesce operator Fix S112 FN: When using null-coalesce operator Aug 29, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left 2 comments to be discussed

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource merged commit 922d983 into master Aug 29, 2023
24 checks passed
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource deleted the Pavel/S112-Repro branch August 29, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix S112 FN: When using null-coalesce operator
2 participants