New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonarLintXmlReader revert to previous ReadContent implementation #6939
Merged
pavel-mikula-sonarsource
merged 1 commit into
feature/SL-exclusions-inclusions
from
cristian/sonarLintXmlParsing
Mar 16, 2023
Merged
SonarLintXmlReader revert to previous ReadContent implementation #6939
pavel-mikula-sonarsource
merged 1 commit into
feature/SL-exclusions-inclusions
from
cristian/sonarLintXmlParsing
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristian-ambrosini-sonarsource
requested a review
from mary-georgiou-sonarsource
March 16, 2023 08:38
cristian-ambrosini-sonarsource
moved this from In progress
to Review in progress
in Best Kanban
Mar 16, 2023
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
mary-georgiou-sonarsource
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned mary-georgiou-sonarsource
Mar 16, 2023
github-actions
bot
moved this from Review in progress
to Review approved
in Best Kanban
Mar 16, 2023
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned cristian-ambrosini-sonarsource
Mar 16, 2023
github-actions
bot
moved this from Review approved
to Review in progress
in Best Kanban
Mar 16, 2023
pavel-mikula-sonarsource
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned pavel-mikula-sonarsource
Mar 16, 2023
pavel-mikula-sonarsource
merged commit Mar 16, 2023
a179722
into
feature/SL-exclusions-inclusions
29 of 30 checks passed
csaba-sagi-sonarsource
pushed a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.