Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard pattern matcher improvement #6919

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

This PR aims to address the comments on the WildcardPatternMatcher, see feature branch PR.

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more polishing

@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 15, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor new comment. There are some unresolved comments above to address.

@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 15, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remove the Path.DirectorySeparatorChar before merging from the last unresolved conversation

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit a60ea62 into feature/SL-exclusions-inclusions Mar 16, 2023
23 of 24 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 16, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the cristian/wildcardPatterMatcher branch March 16, 2023 07:32
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants