New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard pattern matcher improvement #6919
Wildcard pattern matcher improvement #6919
Conversation
7fd2fc3
to
262b3b7
Compare
0253636
to
aa314d4
Compare
262b3b7
to
e841ab6
Compare
aa314d4
to
ab87c17
Compare
ab87c17
to
8bd1769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more polishing
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor new comment. There are some unresolved comments above to address.
analyzers/src/SonarAnalyzer.Common/Helpers/WildcardPatternMatcher.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, remove the Path.DirectorySeparatorChar before merging from the last unresolved conversation
Kudos, SonarCloud Quality Gate passed! |
SonarCloud Quality Gate failed. |
a60ea62
into
feature/SL-exclusions-inclusions
This PR aims to address the comments on the WildcardPatternMatcher, see feature branch PR.