Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language property from SonarLintXmlReader #6905

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

Addresses comments from #6870

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Remove language parameter (Draft title) Remove language property from SonarLintXMLReader Mar 13, 2023
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 13, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource force-pushed the mary/remove-language-parameter branch 2 times, most recently from 28f2a29 to 6f3a31d Compare March 13, 2023 08:32
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title Remove language property from SonarLintXMLReader Remove language property from SonarLintXmlReader Mar 13, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a nitpick

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 13, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Review approved to Review in progress in Best Kanban Mar 13, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kaboom

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Mar 15, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round

@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 15, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Mar 15, 2023
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, just clicking the correct button

@github-actions github-actions bot moved this from In progress to Review approved in Best Kanban Mar 15, 2023
@pavel-mikula-sonarsource
Copy link
Contributor

There's one last nitpick hidden in the unresolved conversations above

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit f0553a7 into feature/SL-exclusions-inclusions Mar 15, 2023
22 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 15, 2023
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/remove-language-parameter branch March 15, 2023 15:10
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants