Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTs: Cleanup ResourceTest folder #6891

Conversation

cristian-ambrosini-sonarsource
Copy link
Contributor

No description provided.

Copy link
Contributor

@csaba-sagi-sonarsource csaba-sagi-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look, and everything seems fine, @mary-georgiou-sonarsource please take another look.

Base automatically changed from cristian/rule-parameters to feature/SL-exclusions-inclusions March 10, 2023 09:28
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one small nitpick

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Mar 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource changed the title Cleanup resource test folder and migrate SonarLint.xml references on UTs Cleanup resource test folder Mar 13, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource changed the title Cleanup resource test folder UTs: Cleanup ResourceTest folder Mar 13, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit d1a8d77 into feature/SL-exclusions-inclusions Mar 13, 2023
19 of 21 checks passed
Best Kanban automation moved this from Review approved to Validate Peach Mar 13, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the cristian/tidying-resource-tests branch March 13, 2023 10:19
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Validate Peach to Done in Best Kanban Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Best Kanban
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants