New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SonarLint exclusion/inclusion IT #6884
Add SonarLint exclusion/inclusion IT #6884
Conversation
2daa48c
to
f29a7e0
Compare
Co-Authored-By: Čaba Šagi <75226367+csaba-sagi-sonarsource@users.noreply.github.com>
f29a7e0
to
f01f121
Compare
eccd739
to
7fe2b29
Compare
analyzers/its/sources/SonarLintExclusions/SonarLintExclusions/NotIncluded.cs
Outdated
Show resolved
Hide resolved
...yzers/its/sources/SonarLintExclusions/SonarLintExclusionsTest/SonarLintExclusionsTest.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor improvements to discuss
analyzers/its/sources/SonarLintExclusions/SonarLintExclusions/NotIncluded.cs
Outdated
Show resolved
Hide resolved
<Value>true</Value> | ||
</Setting> | ||
<Setting> | ||
<Key>sonar.vbnet.ignoreHeaderComments</Key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that both of the properties should refer to a single language
<Key>sonar.vbnet.ignoreHeaderComments</Key> | |
<Key>sonar.cs.ignoreHeaderComments</Key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this is how it is in all the SonarLint.xml config - I'll drop a question to understand if the vbnet case is really needed.
EDIT: This is the same property but for CS and VB.NET.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave as is - that's how it is in the SonarLint.xml
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
63c6870
into
feature/SL-exclusions-inclusions
Fixes #6811