Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonarLint exclusion/inclusion IT #6884

Merged
merged 30 commits into from Mar 10, 2023

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource commented Mar 9, 2023

Fixes #6811

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft March 9, 2023 15:30
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the base branch from master to feature/SL-exclusions-inclusions March 9, 2023 15:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor improvements to discuss

<Value>true</Value>
</Setting>
<Setting>
<Key>sonar.vbnet.ignoreHeaderComments</Key>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that both of the properties should refer to a single language

Suggested change
<Key>sonar.vbnet.ignoreHeaderComments</Key>
<Key>sonar.cs.ignoreHeaderComments</Key>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is how it is in all the SonarLint.xml config - I'll drop a question to understand if the vbnet case is really needed.
EDIT: This is the same property but for CS and VB.NET.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave as is - that's how it is in the SonarLint.xml

analyzers/its/config/SonarLintExclusions/SonarLint.xml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit 63c6870 into feature/SL-exclusions-inclusions Mar 10, 2023
22 of 24 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the mary/add-it branch March 10, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IT to verify the exclusion-inclusion logic works properly
4 participants