Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule S1133: Deprecated code should be removed #6656

Closed
cristian-ambrosini-sonarsource opened this issue Jan 23, 2023 · 3 comments · Fixed by #6669
Closed

New rule S1133: Deprecated code should be removed #6656

cristian-ambrosini-sonarsource opened this issue Jan 23, 2023 · 3 comments · Fixed by #6669
Assignees
@martin-strecker-sonarsource
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: New Feature This hasn't been here before.
Projects
Best Kanban
Milestone
8.53

Comments

@cristian-ambrosini-sonarsource
Copy link
Contributor

cristian-ambrosini-sonarsource commented Jan 23, 2023 •
edited by martin-strecker-sonarsource

S1133

RSpec change: SonarSource/rspec#1512
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. labels Jan 23, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource added this to the 8.52 milestone Jan 23, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource added the Type: New Feature This hasn't been here before. label Jan 23, 2023
Merged
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from To do to In progress in Best Kanban Jan 24, 2023
Merged
@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Jan 25, 2023
@gregory-paidis-sonarsource gregory-paidis-sonarsource removed their assignment Jan 25, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from Review in progress to In progress in Best Kanban Jan 26, 2023
@cristian-ambrosini-sonarsource cristian-ambrosini-sonarsource moved this from In progress to Review in progress in Best Kanban Jan 26, 2023
@github-actions github-actions bot moved this from Review in progress to In progress in Best Kanban Jan 31, 2023
@Corniel
Copy link
Contributor

Corniel commented Feb 1, 2023

What is the difference between this one and CS0612?

@martin-strecker-sonarsource
Copy link
Contributor

CS0612 is raised on the call side while S1133 is raised on the declaration. S1133 is meant to be a reminder to remove the deprecated member with e.g. the next major version release.

@github-actions github-actions bot moved this from In progress to Review in progress in Best Kanban Feb 1, 2023
@Corniel
Copy link
Contributor

Corniel commented Feb 1, 2023

@martin-strecker-sonarsource That makes a lot of sense! It might be worth to explain that difference in the documentation and reference SC0612.

@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Feb 1, 2023
Best Kanban automation moved this from Review approved to Validate Peach Feb 2, 2023
@martin-strecker-sonarsource martin-strecker-sonarsource moved this from Validate Peach to Done in Best Kanban Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: New Feature This hasn't been here before.
Projects
Best Kanban
  
Done
Milestone
8.53
Development

Successfully merging a pull request may close this issue.

New rule S1133: Deprecated code should be removed SonarSource/sonar-dotnet
5 participants
@Corniel @andrei-epure-sonarsource @martin-strecker-sonarsource @cristian-ambrosini-sonarsource @gregory-paidis-sonarsource