From 4a2cebb811bc78ab19998a98f8d1f814e355871e Mon Sep 17 00:00:00 2001 From: mary-georgiou-sonarsource Date: Mon, 13 Mar 2023 08:31:02 +0100 Subject: [PATCH] fix unit tests: Language was the wrong string --- .../src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs b/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs index 0a77709eac2..453a65413b2 100644 --- a/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs +++ b/analyzers/src/SonarAnalyzer.Common/Helpers/SonarLintXmlReader.cs @@ -33,10 +33,10 @@ public class SonarLintXmlReader private readonly SonarLintXml sonarLintXml; private bool? ignoreHeaderComments; - public bool IgnoreHeaderComments(string language = LanguageNames.CSharp) => ignoreHeaderComments ??= ReadBoolean(ReadSettingsProperty($"sonar.{language}.ignoreHeaderComments")); + public bool IgnoreHeaderComments(string language = LanguageNames.CSharp) => ignoreHeaderComments ??= ReadBoolean(ReadSettingsProperty($"sonar.{LanguageXMLName(language)}.ignoreHeaderComments")); private bool? analyzeGeneratedCode; - public bool AnalyzeGeneratedCode(string language = LanguageNames.CSharp) => analyzeGeneratedCode ??= ReadBoolean(ReadSettingsProperty($"sonar.{language}.analyzeGeneratedCode")); + public bool AnalyzeGeneratedCode(string language = LanguageNames.CSharp) => analyzeGeneratedCode ??= ReadBoolean(ReadSettingsProperty($"sonar.{LanguageXMLName(language)}.analyzeGeneratedCode")); private string[] exclusions; public string[] Exclusions => exclusions ??= ReadCommaSeparatedArray(ReadSettingsProperty("sonar.exclusions")); @@ -96,4 +96,6 @@ private static SonarLintXml ParseContent(SourceText sonarLintXml) private static bool ReadBoolean(string str, bool defaultValue = false) => bool.TryParse(str, out var propertyValue) ? propertyValue : defaultValue; + + private string LanguageXMLName(string language) => language.Equals(LanguageNames.CSharp) ? "cs" : "vbnet"; }