/
ParameterLoaderTest.cs
245 lines (210 loc) · 10.6 KB
/
ParameterLoaderTest.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
/*
* SonarAnalyzer for .NET
* Copyright (C) 2015-2023 SonarSource SA
* mailto: contact AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
using System.IO;
using Microsoft.CodeAnalysis.Text;
using SonarAnalyzer.AnalysisContext;
using SonarAnalyzer.Common;
using SonarAnalyzer.Rules.CSharp;
namespace SonarAnalyzer.UnitTest.Helpers
{
[TestClass]
public class ParameterLoaderTest
{
public TestContext TestContext { get; set; }
[TestMethod]
[DataRow("path//aSonarLint.xml")] // different name
[DataRow("path//SonarLint.xmla")] // different extension
public void SetParameterValues_WithInvalidSonarLintPath_DoesNotPopulateParameters(string filePath)
{
// Arrange
var compilation = CreateCompilationWithOption(filePath, SourceText.From(File.ReadAllText("ResourceTests\\SonarLintXml\\All_properties_cs\\SonarLint.xml")));
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(3); // Default value
}
[TestMethod]
[DataRow("a/SonarLint.xml")] // unix path
[DataRow("a\\SonarLint.xml")]
public void SetParameterValues_WithValidSonarLintPath_PopulatesProperties(string filePath)
{
// Arrange
var compilation = CreateCompilationWithOption(filePath, SourceText.From(File.ReadAllText("ResourceTests\\SonarLintXml\\All_properties_cs\\SonarLint.xml")));
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(1); // Value from the xml file
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithIntParameterType_PopulatesProperties()
{
// Arrange
var compilation = CreateCompilationWithOption("ResourceTests\\SonarLintXml\\All_properties_cs\\SonarLint.xml");
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(1); // Value from the xml file
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithStringParameterType_PopulatesProperty()
{
// Arrange
var parameterValue = "1";
var filePath = GenerateSonarLintXmlWithParametrizedRule("S2342", "flagsAttributeFormat", parameterValue);
var compilation = CreateCompilationWithOption(filePath);
var analyzer = new EnumNameShouldFollowRegex(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.FlagsEnumNamePattern.Should().Be(parameterValue); // value from XML file
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithBooleanParameterType_PopulatesProperty()
{
// Arrange
var parameterValue = true;
var filePath = GenerateSonarLintXmlWithParametrizedRule("S1451", "isRegularExpression", parameterValue.ToString());
var compilation = CreateCompilationWithOption(filePath);
var analyzer = new CheckFileLicense(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.IsRegularExpression.Should().Be(parameterValue); // value from XML file
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithoutRuleParameters_DoesNotPopulateProperties()
{
// Arrange
var compilation = CreateCompilationWithOption("ResourceTests\\SonarLintXml\\All_properties_cs\\SonarLint.xml");
var analyzer = new LineLength(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(200); // Default value
}
[TestMethod]
public void SetParameterValues_CalledTwiceAfterChangeInConfigFile_UpdatesProperties()
{
// Arrange
var maxValue = 1;
var ruleParameters = new List<SonarLintXmlRule>()
{
new SonarLintXmlRule()
{
Key = "S1067",
Parameters = new List<SonarLintXmlKeyValuePair>()
{
new SonarLintXmlKeyValuePair()
{
Key = "max",
Value = maxValue.ToString()
}
}
}
};
var sonarLintXml = AnalysisScaffolding.GenerateSonarLintXmlContent(rulesParameters: ruleParameters);
var filePath = TestHelper.WriteFile(TestContext, "SonarLint.xml", sonarLintXml);
var compilation = CreateCompilationWithOption(filePath);
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
analyzer.Maximum.Should().Be(maxValue);
// Modify the in-memory additional file
maxValue = 42;
ruleParameters.First().Parameters.First().Value = maxValue.ToString();
var modifiedSonarLintXml = AnalysisScaffolding.GenerateSonarLintXmlContent(rulesParameters: ruleParameters);
var modifiedFilePath = TestHelper.WriteFile(TestContext, "SonarLint.xml", modifiedSonarLintXml);
compilation = CreateCompilationWithOption(modifiedFilePath);
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
analyzer.Maximum.Should().Be(maxValue);
}
[TestMethod]
[DataRow("")]
[DataRow("this is not an xml")]
[DataRow(@"<?xml version=""1.0"" encoding=""UTF - 8""?><AnalysisInput><Settings>")]
public void SetParameterValues_WithMalformedXml_DoesNotPopulateProperties(string sonarLintXmlContent)
{
// Arrange
var compilation = CreateCompilationWithOption("fakePath\\SonarLint.xml", SourceText.From(sonarLintXmlContent));
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(3); // Default value
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithStringInsteadOfIntParameterType_PopulatesProperty()
{
// Arrange
var parameterValue = "fooBar";
var filePath = GenerateSonarLintXmlWithParametrizedRule("S1067", "max", parameterValue);
var compilation = CreateCompilationWithOption(filePath);
var analyzer = new ExpressionComplexity(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.Maximum.Should().Be(3); // Default value
}
[TestMethod]
public void SetParameterValues_SonarLintFileWithStringInsteadOfBooleanParameterType_PopulatesProperty()
{
// Arrange
var parameterValue = "fooBar";
var filePath = GenerateSonarLintXmlWithParametrizedRule("S1451", "isRegularExpression", parameterValue);
var compilation = CreateCompilationWithOption(filePath);
var analyzer = new CheckFileLicense(); // Cannot use mock because we use reflection to find properties.
// Act
ParameterLoader.SetParameterValues(analyzer, compilation.SonarLintFile());
// Assert
analyzer.IsRegularExpression.Should().BeFalse(); // Default value
}
private static SonarCompilationReportingContext CreateCompilationWithOption(string filePath, SourceText text = null)
{
var options = text is null
? AnalysisScaffolding.CreateOptions(filePath)
: AnalysisScaffolding.CreateOptions(filePath, text);
var compilation = SolutionBuilder.Create().AddProject(AnalyzerLanguage.CSharp).GetCompilation();
var compilationContext = new CompilationAnalysisContext(compilation, options, _ => { }, _ => true, default);
return new(AnalysisScaffolding.CreateSonarAnalysisContext(), compilationContext);
}
private string GenerateSonarLintXmlWithParametrizedRule(string ruleId, string key, string value)
{
var ruleParameters = new List<SonarLintXmlRule>()
{
new SonarLintXmlRule()
{
Key = ruleId,
Parameters = new List<SonarLintXmlKeyValuePair>()
{
new SonarLintXmlKeyValuePair()
{
Key = key,
Value = value
}
}
}
};
return AnalysisScaffolding.CreateSonarLintXml(TestContext, rulesParameters: ruleParameters);
}
}
}