-
Notifications
You must be signed in to change notification settings - Fork 222
/
UnusedStringBuilderTest.cs
150 lines (136 loc) · 5.08 KB
/
UnusedStringBuilderTest.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
/*
* SonarAnalyzer for .NET
* Copyright (C) 2015-2023 SonarSource SA
* mailto: contact AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
using CS = SonarAnalyzer.Rules.CSharp;
using VB = SonarAnalyzer.Rules.VisualBasic;
namespace SonarAnalyzer.UnitTest.Rules;
[TestClass]
public class UnusedStringBuilderTest
{
private readonly VerifierBuilder builderCS = new VerifierBuilder<CS.UnusedStringBuilder>();
private readonly VerifierBuilder builderVB = new VerifierBuilder<VB.UnusedStringBuilder>();
[TestMethod]
public void UnusedStringBuilder_CS() =>
builderCS.AddPaths("UnusedStringBuilder.cs").Verify();
[DataTestMethod]
[DataRow("", false)]
[DataRow("sb.ToString();", true)]
[DataRow("""var a = sb.Append("").Append("").Append("").Append("").ToString().ToLower();""", true)]
[DataRow("sb.CopyTo(0, new char[1], 0, 1);", true)]
[DataRow("sb.GetChunks();", true)]
[DataRow("var a = sb[0];", true)]
[DataRow("""sb?.Append("").ToString().ToLower();""", true)]
[DataRow("""@sb.Append("").ToString();""", true)]
[DataRow("sb.Remove(sb.Length - 1, 1);", true)]
[DataRow("""var a = $"{sb} is ToStringed here";""", true)]
public void UnusedStringBuilder_CSExpressionsTest(string expression, bool compliant)
{
var code = $$"""
using System.Text;
public class MyClass
{
public void MyMethod()
{
var sb = new StringBuilder(); // {{(compliant ? "Compliant" : "Noncompliant")}}
{{expression}}
}
}
""";
var builder = builderCS.AddSnippet(code);
if (compliant)
{
builder.VerifyNoIssueReported();
}
else
{
builder.Verify();
}
}
#if NET
[TestMethod]
public void UnusedStringBuilder_CSharp9() =>
builderCS.AddPaths("UnusedStringBuilder.CSharp9.cs")
.WithOptions(ParseOptionsHelper.FromCSharp9)
.Verify();
[DataTestMethod]
[DataRow("", false)]
[DataRow("sb.ToString();", true)]
[DataRow("""var a = sb.Append("").Append("").Append("").Append("").ToString().ToLower();""", true)]
[DataRow("sb.CopyTo(0, new char[1], 0, 1);", true)]
[DataRow("sb.GetChunks();", true)]
[DataRow("var a = sb[0];", true)]
[DataRow("""sb?.Append("").ToString().ToLower();""", true)]
[DataRow("""@sb.Append("").ToString();""", true)]
[DataRow("sb.Remove(sb.Length - 1, 1);", true)]
[DataRow("""var a = $"{sb} is ToStringed here";""", true)]
public void UnusedStringBuilder_TopLevelStatements(string expression, bool compliant)
{
var code = $$"""
using System.Text;
var sb = new StringBuilder(); // {{(compliant ? "Compliant" : "Noncompliant")}}
{{expression}}
""";
var builder = builderCS.AddSnippet(code).WithTopLevelStatements();
if (compliant)
{
builder.VerifyNoIssueReported();
}
else
{
builder.Verify();
}
}
#endif
[DataTestMethod]
[DataRow("", false)]
[DataRow("sb.ToString()", true)]
[DataRow("""Dim a = sb.Append("").Append("").Append("").Append("").ToString().ToLower()""", true)]
[DataRow("sb.CopyTo(0, New Char(0) {}, 0, 1)", true)]
[DataRow("sb.GetChunks()", true)]
[DataRow("Dim a = sb(0)", true)]
[DataRow("""sb?.Append("").ToString().ToLower()""", true)]
[DataRow("""sb.Append("").ToString()""", true)]
[DataRow("sb.Remove(sb.Length - 1, 1)", true)]
[DataRow("""Dim a = $"{sb} is ToStringed here" """, true)]
[DataRow("""SB.ToString()""", true)]
public void UnusedStringBuilder_VBExpressionsTest(string expression, bool compliant)
{
var code = $$"""
Imports System.Text
Public Class [MyClass]
Public Sub MyMethod()
Dim sb = New StringBuilder() ' {{(compliant ? "Compliant" : "Noncompliant")}}
{{expression}}
End Sub
End Class
""";
var builder = builderVB.AddSnippet(code);
if (compliant)
{
builder.VerifyNoIssueReported();
}
else
{
builder.Verify();
}
}
[TestMethod]
public void UnusedStringBuilder_VB() =>
builderVB.AddPaths("UnusedStringBuilder.vb").Verify();
}