-
Notifications
You must be signed in to change notification settings - Fork 222
/
PrivateStaticMethodUsedOnlyByNestedClass.cs
221 lines (187 loc) · 7.45 KB
/
PrivateStaticMethodUsedOnlyByNestedClass.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
using System;
using System.Diagnostics;
using System.Runtime.InteropServices;
class OuterClass
{
static void OnlyUsedOnceByNestedClass() { } // Noncompliant {{Move this method inside 'NestedClass'.}}
// ^^^^^^^^^^^^^^^^^^^^^^^^^
static void OnlyUsedByNestedClassMultipleTimes() { } // Noncompliant
static void OnlyUsedByNestedClassWithClassName() { } // Noncompliant
static void UsedByMultipleSiblingNestedClasses() { } // Compliant - it needs to stay in the outer class
static void UsedByOuterAndNestedClasses() { } // Compliant - it's used by the outer class, so it needs to stay there
static void UsedBySiblingAndDeeperNestedClasses() { } // Compliant - SiblingNestedClass and DeeperNestedClass both need access to the method, so it must stay in the outer class
static void OnlyUsedByDeeperNestedClass() { } // Noncompliant {{Move this method inside 'DeeperNestedClass'.}}
static void UsedByNestedClassAndDeeperNestedClass() { } // Noncompliant {{Move this method inside 'NestedClass'.}}
static void UsedByDeeperNestedClassesOnTheSameLevel() { } // Noncompliant {{Move this method inside 'NestedClass'.}}
static void UnusedMethod() { } // Compliant - no need to move unused method anywhere
void NotStatic() { } // Compliant - method is not static
static int _outerField; // Compliant - not a method
static int OuterProp { get; set; } // Compliant - not a method
public static void PublicMethod() { } // Compliant - method is not private
protected static void ProtectedMethod() { } // Compliant - method is not private
internal static void InternalMethod() { } // Compliant - method is not private
protected internal static void ProtectedInternalMethod() { } // Compliant - method is not private
private static void PrivateMethod() { } // Noncompliant
private static void PrivateMethod(int arg) { } // Compliant - overloaded version of the previous method, not used anywhere
static T GenericMethod<T>(T arg) => arg; // Noncompliant
// ^^^^^^^^^^^^^
static int Recursive(int n) => Recursive(n - 1); // Noncompliant
static void MutuallyRecursive1() => MutuallyRecursive2(); // FN - both methods could be moved inisde the nested class
static void MutuallyRecursive2() => MutuallyRecursive1();
[DllImport("SomeLibrary.dll")]
private static extern void ExternalMethod(); // Noncompliant
static int UsedOnlyByPropertyInNestedClass() => 42; // Noncompliant
static int UsedOnlyByFieldInitializerInNestedClass() => 42; // Noncompliant
static void UsedOnlyByConstructorInNestedClass() { } // Noncompliant
static void AssignedToDelegateInNestedClass() { } // Noncompliant
static void UsedInNameOfExpressionInNestedClass() { } // Noncompliant
void Foo()
{
UsedByOuterAndNestedClasses();
}
class NestedClass
{
int _nestedField = UsedOnlyByFieldInitializerInNestedClass();
int NestedProp => UsedOnlyByPropertyInNestedClass();
public NestedClass()
{
UsedOnlyByConstructorInNestedClass();
}
static void NestedClassMethodUsedByDeeperNestedClass() { } // Noncompliant {{Move this method inside 'DeeperNestedClass'.}}
void Bar()
{
OnlyUsedOnceByNestedClass();
OnlyUsedByNestedClassMultipleTimes();
OuterClass.OnlyUsedByNestedClassWithClassName();
UsedByMultipleSiblingNestedClasses();
UsedByOuterAndNestedClasses();
UsedByNestedClassAndDeeperNestedClass();
new OuterClass().NotStatic();
_outerField = 42;
OuterProp = 42;
PublicMethod();
ProtectedMethod();
InternalMethod();
ProtectedInternalMethod();
PrivateMethod();
GenericMethod(42);
Recursive(42);
MutuallyRecursive1();
ExternalMethod();
Action methodDelegate = AssignedToDelegateInNestedClass;
string methodName = nameof(UsedInNameOfExpressionInNestedClass);
}
void FooBaz()
{
OnlyUsedByNestedClassMultipleTimes();
}
class DeeperNestedClass
{
void FooBar()
{
OnlyUsedByDeeperNestedClass();
UsedByNestedClassAndDeeperNestedClass();
UsedByDeeperNestedClassesOnTheSameLevel();
UsedBySiblingAndDeeperNestedClasses();
NestedClassMethodUsedByDeeperNestedClass();
}
}
class AnotherDeeperNestedClass
{
void Foo()
{
UsedByDeeperNestedClassesOnTheSameLevel();
}
}
}
class SiblingNestedClass
{
void Baz()
{
UsedByMultipleSiblingNestedClasses();
UsedBySiblingAndDeeperNestedClasses();
}
}
}
class ClassContainsStruct
{
static void OnlyUsedByNestedStruct() { } // Noncompliant
struct NestedStruct
{
void Foo()
{
OnlyUsedByNestedStruct();
}
}
}
struct StructContainsClass
{
private static void OnlyUsedByNestedClass() { } // Noncompliant
class NestedClass
{
void Foo()
{
OnlyUsedByNestedClass();
}
}
}
partial class PartialOuterClass
{
static void OnlyUsedByNestedClass() { } // Compliant - partial classes are often a result of code generation, so their methods shouldn't be moved
static partial void PartialOnlyUsedByNestedClass() { } // Compliant
}
partial class PartialOuterClass
{
static partial void PartialOnlyUsedByNestedClass();
class NestedClass
{
void Foo()
{
OnlyUsedByNestedClass();
PartialOnlyUsedByNestedClass();
}
}
}
[DebuggerDisplay("{UsedByDebuggerDisplay()}")]
class DebugViewClass
{
static string UsedByDebuggerDisplay() => ""; // Noncompliant - FP: should not be moved to nested class, because it's also used by the attribute
class NestedClass
{
void Foo()
{
UsedByDebuggerDisplay();
}
}
}
public class EdgeCaseWithLongCommonPaths
{
private static void StaticMethod() { } // Noncompliant {{Move this method inside 'MiddleTwo'.}}
public class MiddleOne
{
public class MiddleTwo
{
public class Foo
{
public class FooLeaf
{
public void Method() => StaticMethod();
}
}
public class Bar
{
public void Method() => StaticMethod();
public class BarLeaf
{
public void Method() => StaticMethod();
}
}
}
}
public class MiddleTwo {
public void StaticMethod()
{
}
public void Method() => StaticMethod();
}
}