Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity casting issue and add regression test. #6614

Merged
merged 7 commits into from
May 1, 2024

Conversation

Moderocky
Copy link
Member

@Moderocky Moderocky commented Apr 26, 2024

Description

Fixed the entity bug thingy.
I also cleaned up the supertype-finder method so it's a little more useful in these situations.

I don't think any other Entity-returning classes make the same mistake, but there might be syntax returning other types that also gets it wrong.


Target Minecraft Versions: any
Requirements: none
Related Issues: #6612

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Moderocky Moderocky assigned sovdeeth and unassigned sovdeeth Apr 26, 2024
@Moderocky Moderocky added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.8 Targeting a 2.8.X version release labels Apr 26, 2024
cheeezburga added a commit to cheeezburga/Skript that referenced this pull request Apr 28, 2024
- Split the properties and behaviour into their own syntax so the patterns weren't weird to accommodate for that
- Changed LivingEntity to Entity to prevent ClassCastException being thrown (see issue SkriptLang#6612 and PR SkriptLang#6614)
Moderocky added 2 commits May 1, 2024 19:38
@APickledWalrus APickledWalrus merged commit 672de73 into SkriptLang:dev/patch May 1, 2024
5 checks passed
@Moderocky Moderocky deleted the fix-6612 branch May 4, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants