Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sector blocklist #26

Open
n8maninger opened this issue Mar 20, 2023 · 2 comments
Open

Add Sector blocklist #26

n8maninger opened this issue Mar 20, 2023 · 2 comments
Labels
feature A new feature request or enhancement good first issue Good for newcomers

Comments

@n8maninger
Copy link
Member

n8maninger commented Mar 20, 2023

Add the ability for hosts to block sectors by root, preventing them from being stored.

This change would add a new table, 4 new methods on the volume manager, and 4 new endpoints.

persist/sqlite changes

  • Add a new table to init.sql
  • Add a migration to create the table on existing hosts to migrations.go
  • Add methods for add, list, and remove to Store

host/storage changes

  • Add methods from the sqlite store to the Store interface in persist.go
  • Add methods for add, list, and remove to VolumeManager.
  • Keep the blocklist in memory for speed. Load it at startup.
  • Check if the sector root is blocked in VolumeManager.Write and return an error.

api changes

  • Add endpoints to the API for add, list, and remove. Maybe under /sectors/blocklist
@n8maninger n8maninger added feature A new feature request or enhancement and removed enhancement labels May 23, 2023
@n8maninger n8maninger added this to the v1.0.0 milestone Jun 16, 2023
@n8maninger n8maninger removed this from the v1.0.0 milestone Jul 13, 2023
@JonWirtzfeld
Copy link

@n8maninger I'd like to try to get this feature implemented. Looks a little involved so I may be asking some questions!

@n8maninger
Copy link
Member Author

n8maninger commented Oct 19, 2023

@n8maninger I'd like to try to get this feature implemented. Looks a little involved so I may be asking some questions!

Great! I'll assign it to you. Feel free to ping me here or on Discord if you need anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature request or enhancement good first issue Good for newcomers
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

2 participants