Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manager panic #23

Merged
merged 3 commits into from Feb 19, 2024
Merged

Fix manager panic #23

merged 3 commits into from Feb 19, 2024

Conversation

chris124567
Copy link
Member

Fix case where chain.Manager would panic when adding a v1 transaction after the v2 hardfork require height.

@lukechampine
Copy link
Member

I decided to move the check into the Store; I think it's a slight improvement to say "the supplement for a v2 block is defined as empty," rather than checking the height wherever we might need to compute a supplement. ‾\_(ツ)_/‾

@ChrisSchinnerl ChrisSchinnerl merged commit 12c5ec4 into master Feb 19, 2024
6 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the fix-v1-v2-panic branch February 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants