Add wallet apply and revert logic to coreutils #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
requested review from
peterjan and
ChrisSchinnerl
and removed request for
peterjan and
ChrisSchinnerl
n8maninger
force-pushed
the
nate/wallet-updater
branch
from
654da94
to
5adccd9
Compare
n8maninger
force-pushed
the
nate/wallet-updater
branch
from
5adccd9
to
bcb13c5
Compare
n8maninger
commented
Feb 13, 2024
ChrisSchinnerl
previously approved these changes
Feb 15, 2024
peterjan
reviewed
Feb 15, 2024
peterjan
reviewed
Feb 15, 2024
n8maninger
dismissed stale reviews from ChrisSchinnerl and peterjan
via
ea59ca4
ChrisSchinnerl
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds subscriber logic to the wallet package. Instead of duplicating the single address transaction and utxo logic, stores can implement the transaction interface and call
wallet.ApplyChainUpdatesandwallet.RevertChainUpdatefrom their consensus subscriber.