Fix broken parsing of liquid attribute names

Author: lukeh-shopify

.changeset/wicked-balloons-reply.md

@@ -0,0 +1,5 @@
+---
+'@shopify/liquid-html-parser': patch
+---
+
+Fix broken parsing of liquid attribute names

packages/liquid-html-parser/grammar/liquid-html.ohm

@@ -430,7 +430,7 @@ LiquidHTML <: Liquid {
   AttrList = Attr*
 
   Attr =
-    liquidNode | AttrSingleQuoted | AttrDoubleQuoted | AttrUnquoted | attrEmpty
+    AttrSingleQuoted | AttrDoubleQuoted | AttrUnquoted | liquidNode | attrEmpty
 
   attrEmpty = attrName
 

packages/liquid-html-parser/src/stage-1-cst.spec.ts

@@ -1107,6 +1107,19 @@ describe('Unit: Stage 1 (CST)', () => {
         });
       });
 
+      it('should parse liquid attribute names', () => {
+        cst = toLiquidHtmlCST('<img {{ data-name }}="{{ data-value }}"/>');
+        expectPath(cst, '0.name').to.equal('img');
+        expectPath(cst, '0.type').to.equal('HtmlVoidElement');
+        expectPath(cst, '0.attrList.0.type').to.equal('AttrDoubleQuoted');
+        expectPath(cst, '0.attrList.0.name.0.type').to.equal('LiquidVariableOutput');
+        expectPath(cst, '0.attrList.0.name.0.markup.expression.type').to.equal('VariableLookup');
+        expectPath(cst, '0.attrList.0.name.0.markup.expression.name').to.equal('data-name');
+        expectPath(cst, '0.attrList.0.value.0.type').to.equal('LiquidVariableOutput');
+        expectPath(cst, '0.attrList.0.value.0.markup.expression.type').to.equal('VariableLookup');
+        expectPath(cst, '0.attrList.0.value.0.markup.expression.name').to.equal('data-value');
+      });
+
       it(`should parse quoted attributes`, () => {
         [
           { type: 'AttrSingleQuoted', name: 'single', quote: "'" },