Check if prepare argument is a symbol or string #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jan 15, 2024
| if constant.respond_to?(prepare) | ||
| constant.method(prepare) | ||
| constant.method(prepare.to_sym) |
There was a problem hiding this comment.
I think method takes either?
irb(main):002:0> String.new.method(:length)
=> #<Method: String#length()>
irb(main):003:0> String.new.method("length")
=> #<Method: String#length()>
There was a problem hiding this comment.
Oh, just saw your other comment about Sorbet. Should we fix that upstream?
There was a problem hiding this comment.
Yes but Sorbet doesn't know that https://github.com/sorbet/sorbet/blob/5e26c5107bda611cfa2068b75a7d6927ca1e8141/rbi/core/kernel.rbi#L555. I can fix it later, it's not as urgent as this PR.
There was a problem hiding this comment.
andyw8
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Leftover from the refactor https://github.com/Shopify/tapioca/pull/1714/files#diff-8b787801eb4d5ed2047d8b5d37043650443fae0500ae270f8d7ededeb311f27cL68. It causes TypeError's when the argument isn't a symbol or a string.
Implementation
Bring back the previous check, call
to_symto please Sorbet.Tests
Added