Reduce minimum RuboCop version back to ~> 1.51
#612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
config change
|
CI is failing with |
sambostock
force-pushed
the
reduce-required-rubocop-version
branch
from
3f20dbb
to
b5a3b95
Compare
|
It turns out |
rafaelfranca
approved these changes
Feb 14, 2024
As of Rubygems 3.5.6 (included in Ruby 3.2 onwards, and often available in environments with older Ruby versions where Rubygems has been updated), `Gem::Version#<=>` supports passing in a `String`, instead of needing to create a `Gem::Version` to pass in. If we temporarily add a backport, we can use this approach, which makes the version checks in the YAML+ERB config files more straightforward. The backport is done in a separate file so we can leverage the deduplication `require` provides out of the box, so as not to trigger a method redefinition warning. It also means we'll be able to import it in our upcoming plugin config files, rather than duplicating it.
Since we're introducing the
<% if rubocop_version >= "X.YZ"
Dept/Cop:
Enabled: true
<% end %>
approach to configuring RuboCop without requiring a specific version of
the gem (ahead of supporting plugin configs), we should just use that
approach to avoid changing the minimum required version in the next
release.
sambostock
force-pushed
the
reduce-required-rubocop-version
branch
from
b5a3b95
to
f1d087c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're introducing the
approach to configuring RuboCop without requiring a specific version of the gem (ahead of supporting plugin configs), we should just use that approach to avoid changing the minimum required version in the next release.