Disable new cops by default #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shopify's Ruby Style Guide disallows pending cops. That is, any time the development version of Rubocop is updated, any new pending cops will fail CI until we explicitly enable or disable them. However, due to time between releases, consumers having upgraded Rubocop may end up triaging cops themselves to get rid of the pending cops message. Therefore, this switches the config to disable new cops by default, in favour of waiting for us to triage them. Of course, consumers can always choose to override individual cops, or even this entire setting.
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
github-actions
bot
added
the
config change
That is fine. Most time people don't enable new cops in apps. |
rafaelfranca
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify's Ruby Style Guide disallows pending cops. That is, any time the development version of Rubocop is updated, any new pending cops will fail CI until we explicitly enable or disable them.
However, due to time between releases, consumers having upgraded Rubocop may end up triaging cops themselves to get rid of the pending cops message.
Therefore, this switches the config to disable new cops by default, in favour of waiting for us to triage them. Of course, consumers can always choose to override individual cops, or even this entire setting.
馃 This could be considered a breaking change, as the setting applies to all Rubocop cops, but we only triage and provide configuration for those in the main
rubocopgem. This means that any apps wouldn't be warned about pending cops in plugins such asrubocop-rails.