Upgrade to Prism v0.19 #1253
Merged
Upgrade to Prism v0.19 #1253
+5,025
−3,838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Dec 15, 2023
| @@ -4,6 +4,9 @@ | |||
| "[ruby]": { | |||
| "editor.defaultFormatter": "Shopify.ruby-lsp", | |||
| }, | |||
| "search.exclude": { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade to the latest Prism. The only change that impacted us is the new
ImplicitRestNode, but it's a simple fix.I also excluded the
test/fixtures/prismdirectory from the VS Code search since we don't usually search for files there and it pollutes the results when searching for Ruby LSP files.