Use Prism 0.25.0 #285
Merged
Use Prism 0.25.0 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Apr 10, 2024
| @@ -24,6 +24,6 @@ Gem::Specification.new do |spec| | |||
| "Rakefile", | |||
| ] | |||
|
|
|||
| spec.add_dependency("prism", ">= 0.18.0", "< 0.25") | |||
| spec.add_dependency("prism", ">= 0.18.0", "< 0.26") | |||
There was a problem hiding this comment.
Is there a reason we need an upper limit on the version here? Could we do this dependency upgrade automatically if we didn't have it?
There was a problem hiding this comment.
I think were being cautious while Prism was still undergoing a lot of changes, but perhaps we can relax this now. @Morriar, @vinistock ?
There was a problem hiding this comment.
Kevin mentioned there may still be breaking changes shipped in minor versions until Prism achieves 100% compatibility for the Ruby compiler. Let's keep the upper limit.
vinistock
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.