Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs for item removal #12806

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix typo in docs for item removal #12806

merged 2 commits into from
Oct 29, 2024

Conversation

IlanaB
Copy link
Contributor

@IlanaB IlanaB commented Oct 21, 2024

WHY are these changes introduced?

Fixes a typo I noticed at https://polaris.shopify.com/patterns/common-actions/overview#remove

WHAT is this pull request doing?

Changing the spelling of "cursor" in our docs file

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@IlanaB IlanaB requested a review from sarahill October 21, 2024 19:38
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @IlanaB!

@chloerice chloerice added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 22, 2024
@chloerice chloerice removed the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 28, 2024
@chloerice
Copy link
Member

Merging, CI is failing on an error in the website build that can't be reproduced locally and has nothing to do with this two character change.

Screenshot 2024-10-29 at 10 43 28 AM

@chloerice chloerice merged commit 57e6cbe into main Oct 29, 2024
9 of 11 checks passed
@chloerice chloerice deleted the 10-21-fix_typo branch October 29, 2024 14:47
moraleslevi pushed a commit that referenced this pull request Oct 31, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@13.9.1

### Patch Changes

- [#12824](#12824)
[`85c5bb7b4`](85c5bb7)
Thanks [@moraleslevi](https://github.com/moraleslevi)! - Fix hydration
issues with SSR

## polaris.shopify.com@1.1.0

### Minor Changes

- [#12662](#12662)
[`5bb85b547`](5bb85b5)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Removes
unnecessary new badges from navigation

### Patch Changes

- [#12739](#12739)
[`af15611a6`](af15611)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
guidelines


- [#12806](#12806)
[`57e6cbe71`](57e6cbe)
Thanks [@IlanaB](https://github.com/IlanaB)! - Fixed a typo in the
common actions overview

- Updated dependencies
\[[`85c5bb7b4`](85c5bb7)]:
    -   @shopify/polaris@13.9.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants