Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated common action guidelines #12739

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

sarahill
Copy link
Contributor

@sarahill sarahill commented Oct 4, 2024

This PR updates common action guidelines to remove references to using tooltips with icon only buttons.

Why

  • Icons used in buttons should be used for common actions that are universally understood
  • Adding icons to every icon only button gets very busy and overwhelming
  • Tooltips on buttons isn't a pattern that scales to mobile

@sarahill sarahill merged commit af15611 into main Oct 4, 2024
8 checks passed
@sarahill sarahill deleted the update-common-action-guidelines branch October 4, 2024 02:15
moraleslevi pushed a commit that referenced this pull request Oct 31, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@13.9.1

### Patch Changes

- [#12824](#12824)
[`85c5bb7b4`](85c5bb7)
Thanks [@moraleslevi](https://github.com/moraleslevi)! - Fix hydration
issues with SSR

## polaris.shopify.com@1.1.0

### Minor Changes

- [#12662](#12662)
[`5bb85b547`](5bb85b5)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Removes
unnecessary new badges from navigation

### Patch Changes

- [#12739](#12739)
[`af15611a6`](af15611)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
guidelines


- [#12806](#12806)
[`57e6cbe71`](57e6cbe)
Thanks [@IlanaB](https://github.com/IlanaB)! - Fixed a typo in the
common actions overview

- Updated dependencies
\[[`85c5bb7b4`](85c5bb7)]:
    -   @shopify/polaris@13.9.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants