Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove old "new" badges #12662

Merged
merged 6 commits into from
Sep 19, 2024
Merged

[Docs] Remove old "new" badges #12662

merged 6 commits into from
Sep 19, 2024

Conversation

heyjoethomas
Copy link
Contributor

Remove new badges that were added with Uplift/Gen 3 documentation.

Before

Screenshot 2024-09-19 at 11 07 27 AM Screenshot 2024-09-19 at 11 07 31 AM

After

Screenshot 2024-09-19 at 11 07 10 AM Screenshot 2024-09-19 at 11 07 16 AM

Gen 3 has been out long enough the content is no longer "new"

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
kdeldycke Kevin Deldycke
Remove new badges that were added with Uplift/Gen 3 documentation.

Verified

This commit was signed with the committer’s verified signature.
kdeldycke Kevin Deldycke
Add change log
Copy link
Contributor

@sarahill sarahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heyjoethomas heyjoethomas marked this pull request as ready for review September 19, 2024 16:52
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added some suggestion comments to restore some formatting changes that were likely due to the automatic formatting

@heyjoethomas heyjoethomas merged commit 5bb85b5 into main Sep 19, 2024
8 checks passed
@heyjoethomas heyjoethomas deleted the remove-new-badges branch September 19, 2024 18:56
moraleslevi pushed a commit that referenced this pull request Oct 31, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@13.9.1

### Patch Changes

- [#12824](#12824)
[`85c5bb7b4`](85c5bb7)
Thanks [@moraleslevi](https://github.com/moraleslevi)! - Fix hydration
issues with SSR

## polaris.shopify.com@1.1.0

### Minor Changes

- [#12662](#12662)
[`5bb85b547`](5bb85b5)
Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Removes
unnecessary new badges from navigation

### Patch Changes

- [#12739](#12739)
[`af15611a6`](af15611)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
guidelines


- [#12806](#12806)
[`57e6cbe71`](57e6cbe)
Thanks [@IlanaB](https://github.com/IlanaB)! - Fixed a typo in the
common actions overview

- Updated dependencies
\[[`85c5bb7b4`](85c5bb7)]:
    -   @shopify/polaris@13.9.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants