Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unnecessary Array#each_with_index with Array#each #992

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

ashmaroli
Copy link
Contributor

The index parameter is not required in these function blocks as Liquid::ForloopDrop and Liquid::TablerowloopDrop have taken over the responsibility to handle associated array indices.

@pushrax pushrax merged commit c118e6b into Shopify:master Mar 16, 2018
@ashmaroli ashmaroli deleted the each-without-index branch February 24, 2019 07:42
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems-4-0-stable January 11, 2023 15:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants