Rename min/max filters for clarity #958
Merged
+26
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min
andmax
were added in #954. The original implementation behaved as "min
= limit a number to a minimum value" and "max
= limit a number to a maximum value".This makes sense in the context of Liquid, since a filter is generally interpreted as a verb/action, but is confusing in the context of programming languages in general, which tend to have
min
/max
functions that return the minimum/maximum value passed as argument.After realizing this, I flipped the behavior in 282d42f, before realizing that it's not that simple 😛
Given the confusion (I've asked multiple people and got different answers), I propose we rename the filters for clarity.
@nithinbekal @pushrax @davidcornu @fw42 @dylanahsmith thoughts?