Add max and min filters #954
Merged
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushrax
reviewed
Nov 28, 2017
lib/liquid/standardfilters.rb
Outdated
| @@ -355,6 +355,16 @@ def floor(input) | |||
| raise Liquid::FloatDomainError, e.message | |||
| end | |||
|
|
|||
| def max(input, n) | |||
| result = [input, n].map { |number| Utils.to_number(number) }.min | |||
There was a problem hiding this comment.
Allocating an array just for this is not great, we're not running on something fancy like TruffleRuby that can optimize that allocation away.
nithinbekal
force-pushed
the
max-min-filters
branch
from
14c3043 to
c89d724
Compare
|
@pushrax Updated the methods to use conditions instead of allocating arrays, and added additional tests for number-like things. |
pushrax
approved these changes
Nov 29, 2017
dylanahsmith
approved these changes
Nov 29, 2017
Thibaut
approved these changes
Nov 30, 2017
|
|
||
| assert_template_result "4.5", "{{ 4.5 | max:5 }}" | ||
| assert_template_result "5", "{{ width | max:5 }}", 'width' => NumberLikeThing.new(6) | ||
| assert_template_result "4", "{{ width | max:5 }}", 'width' => NumberLikeThing.new(4) |
There was a problem hiding this comment.
Could add a test for {{ 5 | max: width }}
nithinbekal
force-pushed
the
max-min-filters
branch
from
c89d724 to
4bdaaf0
Compare
|
Added tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will introduce
maxandminfilters. An example use case:{%- assign width = 250 -%} {%- if image.width < width -%} {%- assign width = image.width -%} {%- endif -%}The above can be replaced with:
{%- assign width = image.width | max: 250 -%}If invalid inputs are given (eg.
"foo"), they would default to 0 (eg.{{ "foo" | max: 5 }returns0, and{{ "foo" | min:5 }}returns5), which is consistent with other filters that work on numbers (ceil, floor etc), but I haven't added test cases for those.@Thibaut