Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Reduce maximum block nesting in Liquid::BlockBody#parse #944

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

dylanahsmith
Copy link
Contributor

Problem

From #937 (comment)

CI is angry at me because of linter errors (I re-used BlockBody#parse's structure which has more than 3 levels of block nesting), the the rest of the test suite runs successfully.

Solution

Use early returns or next statements to reduce nesting. That way we no longer have a rubocop exception for this method.

@dylanahsmith dylanahsmith merged commit 6c117fd into master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants