Support rendering symbols as strings #920
Conversation
lib/liquid/extensions.rb
Outdated
| @@ -7,6 +7,12 @@ def to_liquid | |||
| end | |||
| end | |||
|
|
|||
| class Symbol # :nodoc: | |||
| def to_liquid | |||
| self | |||
There was a problem hiding this comment.
Do we want to have to deal with the difference between symbols and strings in filters and tags? Or should we use to_s here so that symbols get converted into strings and we don't have to worry about another possible type?
There was a problem hiding this comment.
I'm fairly sure that everything that expects a string does to_s already. This is definitely the case in StandardFilters. (also Symbol#size == Symbol#to_s.size)
If you think it would be better to to_s here though, I considered that also and am not against it.
There was a problem hiding this comment.
There are a few type checks for String in lib/liquid/utils.rb which won't match for a Symbol, however, the distinction is probably more likely to affect application code.
I think that doing to_s would be better to do here if we never want to treat Symbol as being different from String. That seems like it would be better for keeping the language simpler and to avoid having to worry about the edge case of a Symbol being assigned to a variable.
pushrax
force-pushed
the
symbol_to_liquid
branch
from
753ae19 to
bf3e759
Compare
Fixes #919