Use stackprof to test the lack of object allocations #896
+20
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was getting a bunch of warnings when running the tests that were caused by the Spy gem
Solution
We were just using the spy gem in a single test, where we were testing the implementation instead of what we actually cared about, avoiding object allocations. I changed the test to use stackprof to count object allocations so we could assert that none were made.
This also fixes the Gemfile so that we can use stackprof to profile any any of the support MRI versions. Previously it would only install stackprof for MRI ruby 2.1, which is now the minimum ruby version we support.