Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interrupts through includes #1072

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix interrupts through includes #1072

merged 1 commit into from
Mar 12, 2019
+9 −0

Conversation

pushrax
Copy link
Contributor

@pushrax pushrax commented Mar 12, 2019

Changing the interrupt state inside non-block tags (e.g. in the include tag) would not correctly break the parent render loop.

@pushrax
Fix interrupts through includes

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 7D7E90962D9FD507
Learn about vigilant mode
39fecd0
@pushrax pushrax requested review from Thibaut and dylanahsmith March 12, 2019 16:20
@pushrax pushrax merged commit ff99d92 into master Mar 12, 2019
@pushrax pushrax deleted the fix-interrupts branch March 12, 2019 16:26
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems-4-0-stable January 11, 2023 15:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thibaut Thibaut

@dylanahsmith dylanahsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pushrax @Thibaut @dylanahsmith