Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.18.x: compile_cache/iseq.rb:64:in 'fetch': Invalid argument - (Errno::EINVAL) #471

Closed
casperisfine opened this issue Jan 30, 2024 · 1 comment · Fixed by #476
Closed

1.18.x: compile_cache/iseq.rb:64:in 'fetch': Invalid argument - (Errno::EINVAL) #471

casperisfine opened this issue Jan 30, 2024 · 1 comment · Fixed by #476

Comments

@casperisfine
Copy link
Contributor

I started seeing this error after the upgrade, somehow it wasn't caught during my integration testing while developing 1.18.

Looking into it.
@casperisfine casperisfine changed the title 1.18.x: compile_cache/iseq.rb:64:in fetch': Invalid argument - (Errno::EINVAL)` 1.18.x: compile_cache/iseq.rb:64:in 'fetch': Invalid argument - (Errno::EINVAL) Jan 30, 2024
@casperisfine
Copy link
Contributor Author

Example corrupted header:

"\x05\x00\x00\x00\x881R9\xC1\x06z\xC0/IL(\x9E\x03\x00\x00\x00\x00\x00\x00\xDA\x16\xB9e\x00\x00\x00\x00\x00\x00\x00\x00\xE8\x7F\x00\x00\xB8\xBF0\xE4\xD4\e\xB4\xB2\x01_C\x01\x00\x00\x00\x00\xF8\x17z\x8B\xE8\x7F\x00\x00"

And the whole entry was 2376 bytes.

@stanhu stanhu mentioned this issue Jan 31, 2024
Closed
@casperisfine casperisfine mentioned this issue Jan 31, 2024
Merged
casperisfine pushed a commit that referenced this issue Jan 31, 2024
@byroot
Disable stale cache entries revalidation by default
a5b46d0 
Ref: #471
Ref: #474

Since it is still unclear what causes the corruption, and more
people seem to be running into it, I'd rather make it an opt-in
feature until I get to the bottom of this.
@casperisfine casperisfine mentioned this issue Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a cache corruption issue during revalidation Shopify/bootsnap
1 participant
@casperisfine