Improve the Kernel#require patch to avoid warnings
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
fix-require-warning
branch
from
dfe9a75
to
ec79a66
Compare
Fix: #461 Also neither Rubygems nor Zeitwerk bother decorating `Kernel.require`, and no-one requires with `Kernel.require` so likely not worth it, and if anything that offers an escape hatch to bypass Bootsnap.
casperisfine
force-pushed
the
fix-require-warning
branch
from
ec79a66
to
83d5c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #461
Also neither Rubygems nor Zeitwerk bother decorating
Kernel.require, and no-one requires withKernel.requireso likely not worth it, and if anything that offers an escape hatch to bypass Bootsnap.